On 16/04/10 21:13, Jim Meyering wrote: > Pádraig Brady wrote: >> `sudo cp -a non-root-file copy` would not preserve capabilities. >> The attached fixes this and passes all tests. > ... >> Subject: [PATCH] cp: preserve "capabilities" when also preserving file >> ownership >> >> * src/copy.c (copy_reg): Copy xattrs _after_ setting file ownership >> so that capabilities are not cleared when setting ownership. >> * tests/cp/capability: A new root test. >> * tests/Makefile.am (root_tests): Reference the new test. >> * NEWS: Mention the fix. > > Good catch! > The patch looks fine. > Some tiny suggestions:
Thanks for the review. I've just pushed that. cheers, Pádraig.
