On 07/03/10 01:36, Jim Meyering wrote: > Here's the adjusted patch, for review.
Yes, thanks, that looks good and it works for me. > Also, I added a log line for the tests/du/files0-from change. > (BTW, the following is the output from "git format-patch --stdout -1". > It's easy to apply that by saving it in a FILE, then running "git am FILE") Yes, and here's a proposed change to README-hacking to try to record this advice, along with some other good advice you've given me recently: >From ded44a4b21f50faf40aa70695bec20b3822cffd1 Mon Sep 17 00:00:00 2001 From: Paul Eggert <[email protected]> Date: Sat, 3 Jul 2010 18:44:16 -0700 Subject: [PATCH] Add advice about ChangeLogs and synchronizing submodules. * README-hacking: Adjust accordingly. --- README-hacking | 29 +++++++++++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/README-hacking b/README-hacking index fecbf9e..02cb277 100644 --- a/README-hacking +++ b/README-hacking @@ -39,6 +39,12 @@ which are extracted from other source packages: $ ./bootstrap +To use the most-recent gnulib (as opposed to the gnulib version that +the package last synchronized to), do this next: + + $ git submodule foreach git pull origin master + $ git commit -a -m 'build: update gnulib submodule to latest' + And there you are! Just $ ./configure --quiet #[--enable-gcc-warnings] [*] @@ -60,6 +66,29 @@ to use recent system headers. If you configure with this option, and spot a problem, please be sure to send the report to the bug reporting address of this package, and not to that of gnulib, even if the problem seems to originate in a gnulib-provided file. + +* Submitting patches + +If you develop a fix or a new feature, please send it to the +appropriate bug-reporting address as reported by the --help option of +each program. One way to do this is to use vc-dwim +<http://www.gnu.org/software/vc-dwim/>), as follows. + + Run the command "vc-dwim --help", copy its definition of the + "git-changelog-symlink-init" function into your shell, and then run + this function at the top-level directory of the package. + + Edit the ChangeLog file that this command creates, creating a + properly-formatted entry according to the GNU coding standards + <http://www.gnu.org/prep/standards/html_node/Change-Logs.html>. + + Run the command "vc-dwim" and make sure its output looks good. + + Run "vc-dwim --commit". + + Run the command "git format-patch --stdout -1", and email its output + in, using the the output's subject line. + ----- Copyright (C) 2002-2010 Free Software Foundation, Inc. -- 1.7.0.4
