On 12/10/10 22:28, Jim Meyering wrote: > Paul Eggert wrote: >> This is another portability bug caught by the Sun C compiler. >> Without this patch, cc complains: >> >> "sort.c", line 3933: warning: assignment type mismatch: >> pointer to const char "=" pointer to unsigned char >> >> >> * src/sort.c (fold_toupper): Change this back from char to >> unsigned char, fixing a regression introduced in commit >> 59e2e55d0f154a388adc9bac37d2b45f2ba971f8 dated February 26, as the >> C Standard doesn't let you convert from unsigned char * to char * >> without a cast, and the (in theory more portable) style here is to >> convert char values, not pointer values. >> (getmonth): Convert char to unsigned char when needed for >> comparison. > > Calling commit 59e2e55d0f a regression might lead the unwary > to think that it causes sort to malfunction, when in fact, > at worst (afaics), it evokes a warning. > > So how about something like s/regression/problem/ ? > > This feels like enough of a technicality that I'd prefer to defer it.
Note gcc would also warn about this with -Wall, except that we disable the warning with -Wno-pointer-sign in configure.ac So I agree with the change, but s/regression/warning/ cheers, Pádraig.
