Gilles Espinasse wrote: > ----- Original Message ----- > From: "Pádraig Brady" <[email protected]> > To: "Gilles Espinasse" <[email protected]> > Cc: "Jim Meyering" <[email protected]>; <[email protected]> > Sent: Friday, February 18, 2011 11:54 AM > Subject: bug#8074: Fix sparse-pipe test on 2.6.26 kernel > > > ... >> > >> > If I add a dd if=/dev/null of=pipe conv=notrunc,fdatasync, test > reliabily >> > work too. >> > So I added that in attached patch. >> >> Good testing! >> Interesting to see that fdatasync flushes the pipe to disk. >> However it might be more portable/robust to use `wait` >> rather than that dd command? >> >> cheers, >> Pádraig. >> > wait work fine > Find v2 attached
Thanks to both of you. That was just a buggy (racy) test, independent of kernel or distro, so I've adjusted comments accordingly: >From e6067bcb040f110238bd7cbf9f3781f2e149e0c0 Mon Sep 17 00:00:00 2001 From: Gilles Espinasse <[email protected]> Date: Fri, 18 Feb 2011 13:52:21 +0100 Subject: [PATCH] tests: correct racy sparse-to-pipe test * tests/cp/sparse-to-pipe: Wait for backgrounded "cat" to complete before comparing the results. --- tests/cp/sparse-to-pipe | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/cp/sparse-to-pipe b/tests/cp/sparse-to-pipe index 4d39458..9bbaafa 100755 --- a/tests/cp/sparse-to-pipe +++ b/tests/cp/sparse-to-pipe @@ -25,7 +25,11 @@ mkfifo_or_skip_ pipe timeout 10 cat pipe > copy & truncate -s1M sparse || framework_failure_ cp sparse pipe || fail=1 + +# Ensure that the cat has completed before comparing. +wait + cmp sparse copy || fail=1 Exit $fail -- 1.7.4.1.16.g759e8
