On 21/02/11 16:25, Jim Meyering wrote: > Pádraig Brady wrote: >> Hmm, that reminds me that we probably want to: >> >> diff --git a/src/stat.c b/src/stat.c >> index f26dced..5458e48 100644 >> --- a/src/stat.c >> +++ b/src/stat.c >> @@ -273,7 +273,7 @@ human_fstype (STRUCT_STATVFS const *statfsbuf) >> case S_MAGIC_EXT: /* 0x137D */ >> return "ext"; >> case S_MAGIC_EXT2: /* 0xEF53 */ >> - return "ext2/ext3"; >> + return "ext2/ext3/ext4"; >> case S_MAGIC_EXT2_OLD: /* 0xEF51 */ >> return "ext2"; >> case S_MAGIC_FAT: /* 0x4006 */ > > We talked about this two years ago: > > Re: [PATCH] stat: add support for more file system types > http://www.mail-archive.com/[email protected]/msg18898.html > Re: [Bug 485507] RFE: add ext4 to "stat -f" output > http://lists.gnu.org/archive/html/bug-coreutils/2009-02/msg00160.html > > I guess the question should be "do we ever want to change this?". > If so, sooner may be better than later, but I'm not sure it's worth > the risk.
Hmm yes, this is debatable. So your argument is script might be keying on "ext2/ext3" rather than "ext2/ext3/*". Unlikely, but possible. It's a pity ext4 didn't pick a new ID, given that it's not forwards compatible when various features are used, unlike ext[23] where one could always mount as ext2. I guess it's safer to leave alone. cheers, Pádraig.
