bug#12728: v8.20 is missing LIBICONV for factor tool

[Pádraig Brady]

On 10/25/2012 11:21 AM, Jim Meyering wrote:

Thanks for dealing with that.
Along with the fix, please add a syntax-check rule that does something
like this:

   cd src; for i in $(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do
     grep -E "^src_${i}_LDADD .?= .*\$(LIBICONV)" local.mk > /dev/null \
       || echo FAIL $i
   done

Before the fix, it would print this:

   FAIL factor

Pushed with this:

# Ensure programs with authors with non ASCII names link with LIBICONV
sc_check-I18N-AUTHORS:
       @(cd $(srcdir)/src &&                           \
         for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
           grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
             /dev/null || { echo FAIL $$i; exit 1; };            \
         done)

thanks,
Pádraig.