On 05/07/2014 03:24 PM, Paul Eggert wrote:
Thanks for those improvements to the patch; please push.
Thanks for the review.
Furthermore, I was puzzled that there doesn't seem to be
an easier way to create the 0..255 file as this:
printf $(for i in $(seq 0 255); do printf '\\%03o' $i; done; echo '');
At least, the following would avoid the for-loop:
diff --git a/tests/dd/ascii.sh b/tests/dd/ascii.sh
index f2cc375..da6e128 100755
--- a/tests/dd/ascii.sh
+++ b/tests/dd/ascii.sh
@@ -22,7 +22,7 @@ print_ver_ dd
{
# Two lines, EBCDIC " A A" and " A ", followed by all the bytes in order.
printf '\100\301\100\301\100\301\100\100' &&
- printf $(for i in $(seq 0 255); do printf '\\%03o' $i; done; echo '');
+ printf $(printf "\\%03o" $(seq 0 255 ));
} >in || framework_failure_
{
WDYT?
Thanks & have a nice day,
Berny
