On 06/02/2014 05:31 PM, Eric Blake wrote: > On 06/02/2014 02:54 AM, Ben Walton wrote: >> * configure.ac: When looking for a .git checkout, restrict it to git >> checkouts that contain a coreutils-specific tag. >> >> Signed-off-by: Ben Walton <[email protected]> >> --- >> configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index a7a8bfc..96af9be 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings], >> # we're running from a git repo, then auto enable the warnings. >> gl_gcc_warnings=no >> gl_GCC_VERSION_IFELSE([4], [6], >> - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])] >> + [test -f "$srcdir"/.git/refs/tags/v8.22 && >> gl_gcc_warnings=yes])] > > NACK. Git can compress tags to reside in other locations than > .git/refs/tags (run 'git gc --aggressive' for example). The idea of > testing for coreutils.git has merit, but you need to come up with a more > robust test.
Importing the tarball into git for patch management is a fine and useful thing to do, so we should support that. We could probably leverage that .tarball-version is only in the tarball. I'll merge this in and commit in your name: test -d "$srcdir"/.git \ && ! test -f .tarball-version \ && gl_gcc_warnings=yes thanks, Pádraig.
