On 03/09/2015 04:14 PM, Pádraig Brady wrote: >>> + >>> +for size in 1 4095 4096 8191 8192 16383 16384; do >> >> Should you also test 4097 8193 and 16385 (that is, a likely >> 1-more-than-BUFSIZ in the mix)? > > The 1 more is implicit with the \n added by yes(1).
Then you should also test 4094 8190 and 16382, to make sure that a multiple of a non-aligned subset with a small unused tail also works (although I guess the 4097 tests the case of an unused tail if BUFSIZ is 8192, although in that case the unused tail is much larger than a few bytes). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
