tag 22949 fixed thanks On 03/08/2016 02:56 PM, Eric Blake wrote: > Posting this now for the record, although I'm trying to figure out what > the correct patch should be: > > When compiling coreutils 8.25 for cygwin-2.4.1, I got a working > 'install' using CFLAGS=-g, but one that refused to install files when > using CFLAGS=-O2. I finally traced it to: > > lib/set-permissions.c: In function 'set_acls_from_mode': > lib/set-permissions.c:273:1: warning: control reaches end of non-void > function [-Wreturn-type] > > and based on the choice of CFLAGS, it changed whether I was left with 0 > or 1 as a return value from qset_acl().
Appears to have been broken in gnulib commit 2d5ce445, first released in coreutils 8.24. Does this look okay to push on the coreutils side? From bbd6da20f5b2cd46530fdce1f177f1b4202d8eda Mon Sep 17 00:00:00 2001 From: Eric Blake <[email protected]> Date: Tue, 8 Mar 2016 16:01:34 -0700 Subject: [PATCH] build: update gnulib submodule to latest Mainly for: *bdb72bc6 set-permissions: fix compilation on Cygwin --- NEWS | 4 ++++ gnulib | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ae42581..ce46c46 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,10 @@ GNU coreutils NEWS -*- outline -*- ** Bug fixes + cp, mv, and install no longer run into undefined behavior when + handling ACLs on Cygwin and Solaris platforms. [bug introduced in + coreutils-8.24] + stty --help no longer outputs extraneous gettext header lines for translated languages. [bug introduced in coreutils-8.24] diff --git a/gnulib b/gnulib index 85717b6..bdb72bc 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit 85717b68b03bf85016c5079fbbf0c8aa2b182ba6 +Subproject commit bdb72bc645460210bb85f2a5690640a2976f41b0 -- 2.5.0 -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
