On 09/03/17 23:22, Pádraig Brady wrote:
>> BTW, I had only one test FAIL in "make check": tests/misc/sort-debug-
>> keys
>> Is this related to the above?
> I'm guessing that "failure" might be locale related.
> Could you attach the tests/test-suite.log file generated with:
> make TESTS=tests/misc/sort-debug-keys.sh SUBDIRS=. VERBOSE=yes check
Best keep all responses on the list.
The log you sent privately, did indeed indicate a locale issue.
In particular sort was operating in LC_ALL=C mode when
it should have been in fr_FR.utf8. This is the only test
that sets LC_MESSAGES separately to LC_COLLATE etc.
so perhaps if we use LC_ALL for each sort invocation in
this test, it avoids this particular issue on your system?
Can you try running the above make check command again,
with the attached patch applied.
thanks,
Pádraig
diff --git a/tests/misc/sort-debug-keys.sh b/tests/misc/sort-debug-keys.sh
index f90aa0f..cb03a1f 100755
--- a/tests/misc/sort-debug-keys.sh
+++ b/tests/misc/sort-debug-keys.sh
@@ -324,13 +324,13 @@ if test "$LOCALE_FR_UTF8" != "none"; then
echo ' 1²---++3 1,234 Mi' |
LC_ALL=C sort --debug -k2g -k1b,1
echo ' 1²---++3 1,234 Mi' |
- LC_COLLATE=$f LC_CTYPE=$f LC_NUMERIC=$f LC_MESSAGES=C \
- sort --debug -k2g -k1b,1
+ LC_ALL=$f sort --debug -k2g -k1b,1
echo '+1234 1234Gi 1,234M' |
- LC_COLLATE=$f LC_CTYPE=$f LC_NUMERIC=$f LC_MESSAGES=C \
- sort --debug -k1,1n -k1,1g \
- -k1,1h -k2,2n -k2,2g -k2,2h -k3,3n -k3,3g -k3,3h
- ) > out
+ LC_ALL=$f sort --debug \
+ -k1,1n -k1,1g -k1,1h \
+ -k2,2n -k2,2g -k2,2h \
+ -k3,3n -k3,3g -k3,3h
+ ) | sed 's/^^ .*/^ no match for key/' > out
compare exp out || fail=1
fi
