-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 13/08/17 11:22, Jim Meyering wrote: > On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady <[email protected]> > wrote: >> On 11/08/17 11:49, A. Wilcox wrote: >> >>> FAIL: tests/misc/csplit-io-err ============================== >> This was due to an inconsistency in the errors output by seq. A >> fix for that buglet is attached. >> >>> FAIL: tests/misc/printf-surprise >>> ================================ >> Depending on exit 141 couples the script to the value of SIGPIPE >> and to the shell implementation (ksh will return 269 here for >> e.g.). So I've attached a solution that should hopefully work in >> all situations. >> >>> FAIL: tests/misc/sort-debug-warn >>> ================================ >> This was due to an assumption that for "missing" locales that >> sort would fail to C rather than C.UTF8. I've adjusted sort to >> not assume that in the attached. > > Nice work. All three patches looks fine. You might want to insert > "in https://bugs.gnu.org/28054"; at the end of each log message. > > Considering the use of "yes | :", even though there's an identical > prior use in tests/misc/seq-epipe.sh, I wondered if there exists a > shell/system where that would infloop. Maybe paranoid overkill, > but inserting a timeout would avoid the possibility. >
I can confirm that seq and printf-surprise are fixed by these patches. The sort-debug-warn test still fails, because "failed to set locale" is not printed on musl (missing locales are redirected to C.UTF8). Also, the seq-epipe patch fixes the grep but not the comment directly above it. Thank you for your efforts and the fixes. Best, - --arw - -- A. Wilcox (awilfox) Project Lead, Adélie Linux http://adelielinux.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZlnMzAAoJEMspy1GSK50UUsIQALmcw3yfChX9yrY/RwGTTKtP FX3K6h1IoTOh9pQRN3cO/AitUYTrQ0CMF3HyOw1eY41g2Cy7l5uFf36bZuXYOghc WkWk8K3uuvlvkJbIDbszsVzXkHjhoigAC0mcljORXPrTXCS4CpmcRLlaH/HI0niV p1pk64dvNJhgdD/O7M9vatj8s0RH86HleWf0Jl87Vl7wBXfPnB5V4Uu9hpCxRWy6 j0pfZpaOmqbAYLxjWDWfOlfJq0BOFKrtTy4SHhUF1r2CG88WVVSpr1RD/bM+SVkr R9LT/XMXw1tZ82z76AIn2+4KFaunRGhSbOulmhs2yCHORHhgc8jyomSvS8oh47yK EmMgT//VN6hJsKDBYQ2fkiFvrRd4gbf2tXKU92J1KfewoB23wgHvG1EahiSCFUA5 la9xSIZ4X8IIGIiNnHvooxITITdC8oGct8XaLcBfiHYz2GXihAyI0gX+Sc4gL7PI uyK9C2/I3Tw6zJslU+lPtCCwGVUpwLH1LWRxy0YAQn8ejI7eOeK6QNvmsX/tJXEf 5NjauAA5Hca4d11Nq6hRZxkTAsEdbvxupvOQ9EcWoRyLqIj2ayaCvP7VuBjrNYLF huL7oXUGPD81duPaDE1ALPyflG9O70NEmQdXVqv3mLSpkdmbKNzjZZJJ80UV6lXw eLgWSdw8MIQqXUNYMnmo =h0SV -----END PGP SIGNATURE-----
