On 3/17/2019 15:28, Paul Eggert wrote:
John Marino wrote:
After applying the recent patch to 8.31 ln to fix functionality on
solaris 10, I saw some improvement but I think there's something else
wrong.
e.g. # ln -s /raven/etc/fonts/conf.avail/50-user.conf .
ln: failed to create symbolic link '.': Invalid argument
Thanks. Could you please try the attached patch, which I installed on
master?
Also, please try running 'make check'. It should catch bugs like this.
Okay, that seems to fix the regression on ln.
I ran the test in a limited environment, which is why many of the tests
were skipped. However, there was one failure with tee you should look
at (attached).
============================================================================
Testsuite summary for GNU coreutils 8.31
============================================================================
# TOTAL: 616
# PASS: 405
# SKIP: 210
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
Regards,
John
FAIL: tests/misc/tee
====================
++ initial_cwd_=/construction/coreutils/coreutils-8.31
+++ testdir_prefix_
+++ printf gt
++ pfx_=gt
+++ mktempd_ /construction/coreutils/coreutils-8.31 gt-tee.sh.XXXX
+++ case $# in
+++ destdir_=/construction/coreutils/coreutils-8.31
+++ template_=gt-tee.sh.XXXX
+++ MAX_TRIES_=4
+++ case $destdir_ in
+++ destdir_slash_=/construction/coreutils/coreutils-8.31/
+++ case $template_ in
++++ unset TMPDIR
+++ d=/construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
+++ case $d in
+++ :
+++ test -d /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
++++ ls -dgo /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
+++ perms='drwx------ 2 117 Mar 17 21:09
/construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa'
+++ case $perms in
+++ :
+++ echo /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
+++ return
++ test_dir_=/construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
++ cd /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
++ gl_init_sh_nl_='
'
++ IFS='
'
++ for sig_ in 1 2 3 13 15
+++ expr 1 + 128
++ eval 'trap '\''Exit 129'\'' 1'
+++ trap 'Exit 129' 1
++ for sig_ in 1 2 3 13 15
+++ expr 2 + 128
++ eval 'trap '\''Exit 130'\'' 2'
+++ trap 'Exit 130' 2
++ for sig_ in 1 2 3 13 15
+++ expr 3 + 128
++ eval 'trap '\''Exit 131'\'' 3'
+++ trap 'Exit 131' 3
++ for sig_ in 1 2 3 13 15
+++ expr 13 + 128
++ eval 'trap '\''Exit 141'\'' 13'
+++ trap 'Exit 141' 13
++ for sig_ in 1 2 3 13 15
+++ expr 15 + 128
++ eval 'trap '\''Exit 143'\'' 15'
+++ trap 'Exit 143' 15
++ trap remove_tmp_ 0
+ path_prepend_ ./src
+ test 1 '!=' 0
+ path_dir_=./src
+ case $path_dir_ in
+ abs_path_dir_=/construction/coreutils/coreutils-8.31/./src
+ case $abs_path_dir_ in
+
PATH=/construction/coreutils/coreutils-8.31/./src:/construction/coreutils/coreutils-8.31/src:/usr/xpg4/bin:/bin:/usr/bin:/raven/toolchain/gcc8/bin:/raven/toolchain/bin:/raven/sbin:/raven/bin:/sbin:/usr/sbin
+ create_exe_shims_ /construction/coreutils/coreutils-8.31/./src
+ case $EXEEXT in
+ return 0
+ shift
+ test 0 '!=' 0
+ export PATH
+ print_ver_ tee
+ require_built_ tee
+ skip_=no
+ for i in '"$@"'
+ case " $built_programs " in
+ test no = yes
+ test yes = yes
+ local i
+ for i in '$*'
+ env tee --version
tee (GNU coreutils) 8.31
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Mike Parker, Richard M. Stallman, and David MacKenzie.
+ echo line
+ for n in 0 1 2 12 13
++ seq 0
+ files=
+ rm -f
+ tee
+ for f in out '$files'
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ for n in 0 1 2 12 13
++ seq 1
+ files=1
+ rm -f 1
+ tee 1
+ for f in out '$files'
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ for f in out '$files'
+ compare sample 1
+ compare_dev_null_ sample 1
+ test 2 = 2
+ test xsample = x/dev/null
+ test x1 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 1
+ diff -u sample 1
+ for n in 0 1 2 12 13
++ seq 2
+ files='1
2'
+ rm -f 1 2
+ tee 1 2
+ for f in out '$files'
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ for f in out '$files'
+ compare sample 1
+ compare_dev_null_ sample 1
+ test 2 = 2
+ test xsample = x/dev/null
+ test x1 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 1
+ diff -u sample 1
+ for f in out '$files'
+ compare sample 2
+ compare_dev_null_ sample 2
+ test 2 = 2
+ test xsample = x/dev/null
+ test x2 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 2
+ diff -u sample 2
+ for n in 0 1 2 12 13
++ seq 12
+ files='1
2
3
4
5
6
7
8
9
10
11
12'
+ rm -f 1 2 3 4 5 6 7 8 9 10 11 12
+ tee 1 2 3 4 5 6 7 8 9 10 11 12
+ for f in out '$files'
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ for f in out '$files'
+ compare sample 1
+ compare_dev_null_ sample 1
+ test 2 = 2
+ test xsample = x/dev/null
+ test x1 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 1
+ diff -u sample 1
+ for f in out '$files'
+ compare sample 2
+ compare_dev_null_ sample 2
+ test 2 = 2
+ test xsample = x/dev/null
+ test x2 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 2
+ diff -u sample 2
+ for f in out '$files'
+ compare sample 3
+ compare_dev_null_ sample 3
+ test 2 = 2
+ test xsample = x/dev/null
+ test x3 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 3
+ diff -u sample 3
+ for f in out '$files'
+ compare sample 4
+ compare_dev_null_ sample 4
+ test 2 = 2
+ test xsample = x/dev/null
+ test x4 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 4
+ diff -u sample 4
+ for f in out '$files'
+ compare sample 5
+ compare_dev_null_ sample 5
+ test 2 = 2
+ test xsample = x/dev/null
+ test x5 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 5
+ diff -u sample 5
+ for f in out '$files'
+ compare sample 6
+ compare_dev_null_ sample 6
+ test 2 = 2
+ test xsample = x/dev/null
+ test x6 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 6
+ diff -u sample 6
+ for f in out '$files'
+ compare sample 7
+ compare_dev_null_ sample 7
+ test 2 = 2
+ test xsample = x/dev/null
+ test x7 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 7
+ diff -u sample 7
+ for f in out '$files'
+ compare sample 8
+ compare_dev_null_ sample 8
+ test 2 = 2
+ test xsample = x/dev/null
+ test x8 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 8
+ diff -u sample 8
+ for f in out '$files'
+ compare sample 9
+ compare_dev_null_ sample 9
+ test 2 = 2
+ test xsample = x/dev/null
+ test x9 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 9
+ diff -u sample 9
+ for f in out '$files'
+ compare sample 10
+ compare_dev_null_ sample 10
+ test 2 = 2
+ test xsample = x/dev/null
+ test x10 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 10
+ diff -u sample 10
+ for f in out '$files'
+ compare sample 11
+ compare_dev_null_ sample 11
+ test 2 = 2
+ test xsample = x/dev/null
+ test x11 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 11
+ diff -u sample 11
+ for f in out '$files'
+ compare sample 12
+ compare_dev_null_ sample 12
+ test 2 = 2
+ test xsample = x/dev/null
+ test x12 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 12
+ diff -u sample 12
+ for n in 0 1 2 12 13
++ seq 13
+ files='1
2
3
4
5
6
7
8
9
10
11
12
13'
+ rm -f 1 2 3 4 5 6 7 8 9 10 11 12 13
+ tee 1 2 3 4 5 6 7 8 9 10 11 12 13
+ for f in out '$files'
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ for f in out '$files'
+ compare sample 1
+ compare_dev_null_ sample 1
+ test 2 = 2
+ test xsample = x/dev/null
+ test x1 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 1
+ diff -u sample 1
+ for f in out '$files'
+ compare sample 2
+ compare_dev_null_ sample 2
+ test 2 = 2
+ test xsample = x/dev/null
+ test x2 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 2
+ diff -u sample 2
+ for f in out '$files'
+ compare sample 3
+ compare_dev_null_ sample 3
+ test 2 = 2
+ test xsample = x/dev/null
+ test x3 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 3
+ diff -u sample 3
+ for f in out '$files'
+ compare sample 4
+ compare_dev_null_ sample 4
+ test 2 = 2
+ test xsample = x/dev/null
+ test x4 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 4
+ diff -u sample 4
+ for f in out '$files'
+ compare sample 5
+ compare_dev_null_ sample 5
+ test 2 = 2
+ test xsample = x/dev/null
+ test x5 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 5
+ diff -u sample 5
+ for f in out '$files'
+ compare sample 6
+ compare_dev_null_ sample 6
+ test 2 = 2
+ test xsample = x/dev/null
+ test x6 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 6
+ diff -u sample 6
+ for f in out '$files'
+ compare sample 7
+ compare_dev_null_ sample 7
+ test 2 = 2
+ test xsample = x/dev/null
+ test x7 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 7
+ diff -u sample 7
+ for f in out '$files'
+ compare sample 8
+ compare_dev_null_ sample 8
+ test 2 = 2
+ test xsample = x/dev/null
+ test x8 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 8
+ diff -u sample 8
+ for f in out '$files'
+ compare sample 9
+ compare_dev_null_ sample 9
+ test 2 = 2
+ test xsample = x/dev/null
+ test x9 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 9
+ diff -u sample 9
+ for f in out '$files'
+ compare sample 10
+ compare_dev_null_ sample 10
+ test 2 = 2
+ test xsample = x/dev/null
+ test x10 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 10
+ diff -u sample 10
+ for f in out '$files'
+ compare sample 11
+ compare_dev_null_ sample 11
+ test 2 = 2
+ test xsample = x/dev/null
+ test x11 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 11
+ diff -u sample 11
+ for f in out '$files'
+ compare sample 12
+ compare_dev_null_ sample 12
+ test 2 = 2
+ test xsample = x/dev/null
+ test x12 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 12
+ diff -u sample 12
+ for f in out '$files'
+ compare sample 13
+ compare_dev_null_ sample 13
+ test 2 = 2
+ test xsample = x/dev/null
+ test x13 = x/dev/null
+ return 2
+ case $? in
+ compare_ sample 13
+ diff -u sample 13
+ tee -
+ compare sample ./-
+ compare_dev_null_ sample ./-
+ test 2 = 2
+ test xsample = x/dev/null
+ test x./- = x/dev/null
+ return 2
+ case $? in
+ compare_ sample ./-
+ diff -u sample ./-
+ compare sample out
+ compare_dev_null_ sample out
+ test 2 = 2
+ test xsample = x/dev/null
+ test xout = x/dev/null
+ return 2
+ case $? in
+ compare_ sample out
+ diff -u sample out
+ compare /dev/null err
+ compare_dev_null_ /dev/null err
+ test 2 = 2
+ test x/dev/null = x/dev/null
+ test -s err
+ return 0
+ return 0
+ test -w /dev/full
+ mkfifo_or_skip_ fifo
+ test 1 = 1
+ mkfifo fifo
+ read_fifo
+ yes
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
Broken Pipe
+ pipe_status=141
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ returns_ 141 timeout 10 tee ./e/noent
++ wc -l
+ test 2 = 1
+ cat err
tee: ./e/noent: No such file or directory
./tests/init.sh: line 118: 3853 Broken Pipe "$@"
+ fail=1
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ timeout 10 tee -p
++ wc -l
+ test 0 = 0
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ returns_ 1 timeout 10 tee --output-error=warn
++ wc -l
+ test 1 = 1
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ returns_ 1 timeout 10 tee --output-error=exit /dev/null
++ wc -l
+ test 1 = 1
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ returns_ 1 timeout 10 tee --output-error=exit ./e/noent
++ wc -l
+ test 1 = 1
+ read_fifo
+ timeout 10 dd count=1 if=fifo of=/dev/null status=none
+ yes
+ timeout 10 tee --output-error=exit-nopipe
++ wc -l
+ test 0 = 0
+ wait
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ test '' = yes
+ cd /construction/coreutils/coreutils-8.31
+ chmod -R u+rwx /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
+ rm -rf /construction/coreutils/coreutils-8.31/gt-tee.sh.NJqa
+ exit 1
FAIL tests/misc/tee.sh (exit status: 1)
