bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod()

[Pádraig Brady]

On 06/01/2023 15:23, Ondrej Valousek wrote:

This patch replaces set_acl() funclion call with chmod_or_fchmod()
Both functions works (AFAIK) the same way (at least in Linux) so should be 
possible.
Using chmod_or_fchmod would also help us to reduce dependency on libacl
(see the forthcoming patch to qcopy-acl.c from Gnulib).

The "at least in Linux" qualification worries me.
Having a very quick look at the qset_acl() code suggests
it clears ACLs on some platforms at least,
which chmod_or_fchmod() does not.
Am I reading that wrong?

thanks,
Pádraig