Pádraig Brady <p...@draigbrady.com> writes:

> Logic looks good.
> The --help for -E is too wordy I think.
> I would squash this in instead.
>
> thanks!
> Padraig
>
> diff --git a/src/realpath.c b/src/realpath.c
> index b06e5e845..1f7882b49 100644
> --- a/src/realpath.c
> +++ b/src/realpath.c
> @@ -72,11 +72,8 @@ usage (int status)
>   Print the resolved absolute file name.\n\
>   "), stdout);
>         fputs (_("\
> -  -E, --canonicalize           canonicalize by following every symlink in\n\
> -                               every component of the given name 
> recursively;\
> +  -E, --canonicalize           all but the last component must exist 
> (default)\
>   \n\
> -                               all but the last component must exist\n\
> -                               (this is the default)\n\
>     -e, --canonicalize-existing  all components of the path must exist\n\
>     -m, --canonicalize-missing   no path components need exist or be a 
> directory\
>   \n\

Thanks, I pushed it with that change.

I lazily copied the long description from 'readlink'. The longer
description probably makes sense there because canonicalizing file names
isn't its primary purpose.

Collin



Reply via email to