Hello, I'm not sure what exactly is the problem, but ./bootstrap or
./configure fails.  At least as long as we keep the "EXTRA_DIST =
DISTFILES" in Makefile.am in the ./rmt subdirectory.

I'm not sure if that DISTFILES file really needs to be distributed, so
the first obvious "fix" which comes to my mind is to drop that
statement.  Does this make sense?  Is there a better fix?

Broken "make dist" is blocking my RPM CI/CD attempt for GNU cpio against
the Fedora/RHEL distributions, so I am currently doing ugly hacks:
https://github.com/praiskup/cpio/blob/0769df031c767e64a4106ca377a64df934523011/.github/setup/copr-custom-script#L33

Pavel
>From 7bb5cd4f528b67b6e35e14ed537ae39b53531b63 Mon Sep 17 00:00:00 2001
From: Pavel Raiskup <prais...@redhat.com>
Date: Wed, 17 May 2023 17:47:20 +0200
Subject: [PATCH] rmt/paxlib: fix the build with the latest autotools

The "make dist" command fails for GNU cpio on Fedora 38:

    make[4]: Entering directory '/home/praiskup/rh/projects/cpio/rmt'
    make[4]: *** No rule to make target 'DISTFILES', needed by 'distdir-am'.  Stop.

Autotools installed:

    automake-1.16.5-11.fc38.noarch
    autoconf-2.71-5.fc38.noarch

* paxlib/Makefile.am: Drop EXTRA_DIST spec.
* rmt/Makefile.am: Drop the EXTRA_DIST spec.
---
 paxlib/Makefile.am | 2 --
 rmt/Makefile.am    | 2 --
 2 files changed, 4 deletions(-)

diff --git a/paxlib/Makefile.am b/paxlib/Makefile.am
index 2561271..0dedb89 100644
--- a/paxlib/Makefile.am
+++ b/paxlib/Makefile.am
@@ -34,8 +34,6 @@ libpax_a_SOURCES = \
  tarbuf.c\
  rtape.c
 
-EXTRA_DIST = DISTFILES
-
 BUILT_SOURCES=localedir.h
 localedir = $(datadir)/locale
 
diff --git a/rmt/Makefile.am b/rmt/Makefile.am
index 643bda0..968121b 100644
--- a/rmt/Makefile.am
+++ b/rmt/Makefile.am
@@ -23,8 +23,6 @@ EXTRA_PROGRAMS = rmt
 
 rmt_SOURCES = rmt.c
 
-EXTRA_DIST = DISTFILES
-
 AM_CPPFLAGS = -I$(top_srcdir)/gnu -I../ -I../gnu -I$(top_srcdir)/lib \
   -I$(top_srcdir)/paxlib
 
-- 
2.40.1

Reply via email to