After a long and painful bug hunt, I've finally found out what caused
all our Kerberos authentication to break when we upgraded from
cvs-1.9.29 to cvs-1.10.7.

The bug still applies to cvs-1.10.8... it was caused by an
uninitialized CVS_Username.  Attached is a patch that makes it work
for me, YMMV.

2000-03-17  Gordon Matzigkeit  <[EMAIL PROTECTED]>

        * server.c (switch_to_user): Initialize CVS_Username here,
          since none of the Kerberos authentication methods do so.

-- 
 Gordon Matzigkeit <[EMAIL PROTECTED]>  //\ I'm a FIG (http://fig.org/)
Committed to freedom and diversity \// I use GNU (http://gnu.fig.org/)

--- cvs-1.10.7/src/server.c~    Fri Mar 17 08:52:28 2000
+++ cvs-1.10.7/src/server.c     Fri Mar 17 09:21:19 2000
@@ -5187,6 +5187,13 @@
        the client.  */
     umask (0);

+    /* Make sure our CVS_Username has been set. */
+    if (! CVS_Username)
+      {
+       CVS_Username = xmalloc (strlen (username) + 1);
+       strcpy (CVS_Username, username);
+      }
+
 #if HAVE_PUTENV
     /* Set LOGNAME and USER in the environment, in case they are
        already set to something else.  */

Reply via email to