I have a backpatch against 1.10.8 now, as well. If anybody's interested, I'll post it.
Derek
--
Derek Price CVS Solutions Architect ( http://CVSHome.org )
mailto:[EMAIL PROTECTED] OpenAvenue ( http://OpenAvenue.com )
--
My name is not Dr. Death.
My name is not Dr. Death.
My name is not Dr. Death...
- Bart Simpson on chalkboard, _The Simpsons_
"Derek R. Price" wrote:
> I found and fixed a few minor bugs in my scripting hook stuff. There were
>intermittent core dumps when using the commitinfo hook and neither the taginfo hook
>nor the commitinfo hook were passing spaces or
> other strange characters in file names properly. I added a few more sanity checks
>for the spaces in file names.
>
> I've attached two patches. The first is additive to my first patch, if you've
>already tried it. The second is a full diff from the current dev version of CVS.
>
> They both pass all the sanity tests.
>
> Derek
> --
> Derek Price CVS Solutions Architect ( http://CVSHome.org )
> mailto:[EMAIL PROTECTED] OpenAvenue ( http://OpenAvenue.com )
> --
> I will not get very far with this attitude.
> I will not get very far with this attitude.
> I will not get very far with this attitude...
>
> - Bart Simpson on chalkboard, _The Simpsons_
>
> "Derek R. Price" wrote:
>
> > I've seen a lot of patches come through this list which were intended to
> > pass some piece of information to one script hook or another, and when
> > I went to put mine in I noticed that the easy way was likely to destroy
> > backwards compatibility with old repositories.
> >
> > Anyway, here's what I did:
> >
> > I rewrote the code which calls the scripts for all of the scripting hook
> > files (commitinfo, editinfo, verifymsg, loginfo, taginfo, notify) to use
> > a single interface to create the command line which accepts arguments in
> > a manner inspired by printf. I won't get into detail here. You can
> > look at the documentation and comments and the code itself for that, but
> > here is what the patch does:
> >
> > 1) The executable will work with all existing repositiories but may
> > start printing deprecation warnings if you are making use of scripting
> > hooks.
> > a) for commitinfo, editinfo, verifymsg, & taginfo this is because
> > CVS prefers hitherto implicit arguments to be specified explicitly.
> > b) for loginfo this is because I could not provide all the new
> > features and support the old behavior completely at the same time
> > without a bit of a mess. To become completely compatible with the new
> > format, loginfo scripts may need to be updated to accept multiple
> > arguments instead of the single argument string, but this provides
> > several advantages including easier parsing of file names containing odd
> > characters like whitespace and commas.
> > c) complete instructions for updating an old repository are
> > included in the patch to the Cederqvist. After applying this patch,
> > read the section on "Commit files" and the specific admin files for more
> > information.
> >
> > 2) All arguments passed to scripts now require (except in the case of
> > deprecated implicit arguments noted above) format strings in the command
> > line templates in the hook files.
> >
> > 3) Adding new data which can be passed through a hook to a script
> > should now only require a single line change to the source, not counting
> > getting the data into the function which parses the hook files in the
> > first place and the syntax is extensible enough that existing hook files
> > shouldn't ever need any further updating to be compatible with future
> > version of CVS unless they wish scripts to process some newly available
> > piece of data.
> >
> > Please review the docs and, if so motivated, try it out. I would love
> > feedback. Let me know how the documented features sound, if you can
> > find any bugs, and if you can think of any useful sanity checks I may
> > have missed.
> >
> > The patch is against the latest development version of CVS. I haven't
> > tried it on the latest incremental stable release.
> >
> > Thanks for your time.
> >
> > Derek
> >
> > --
> > Derek Price CVS Solutions Architect ( http://CVSHome.org )
> > mailto:[EMAIL PROTECTED] OpenAvenue ( http://OpenAvenue.com )
> > --
> > 170. If you try to fail, and succeed, which have you done?
