Conrad T. Pino wrote:

>This patch changes all <winsock.h> to <sys/socket.h> which includes
><winsock2.h> and "gethostname" prototype in "windows-NT/unistd.h"
>is modified to match <winsock2.h> prototype.
>
>IMO all <winsock.h> should be replaced with <sys/socket.h> which
>will include the appropriate Windows header file.
>  
>

This patch looks good, except I think you should carry through and
simplify - remove all the #ifdef WINSOCK_H #else stuff, adding an empty
windows-NT/netinet/in.h, if necessary.

>I suggest moving to Winsock2 but IMO that is optional.
>  
>

Sure.  Whatever you think is best.

Regards,

Derek

-- 
Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 717.579.6168
f: +1 717.234.3125
<mailto:[EMAIL PROTECTED]>




_______________________________________________
Bug-cvs mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/bug-cvs

Reply via email to