-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Derek R. Price on 4/11/2006 8:48 AM:
> No one has objected in about a week and this patch plus a small typo fix > in m4/full-header-path.m4 is passing CVS nightly testing on some dozen > platforms, so I committed it to GNULIB. Sorry I haven't reviewed earlier. In general, I like the idea of the patch; some nitpicks below. > 2006-04-11 Derek Price <[EMAIL PROTECTED]> > Paul Eggert <[EMAIL PROTECTED]> > > * lib/inttypes.h: New file. > * lib/strtoimax.c: Assume <inttypes.h>. > * m4/_inttypes_h.m4, m4/full-header-path.m4, m4/include_next: New > files. > * modules/inttypes: New file. > * modules/strtoimax, modules/strtoumax: Depend on inttypes. > +++ lib/inttypes.h 11 Apr 2006 14:27:29 -0000 + * + * Currently, if the system <inttypes.h> is missing or not C99 compliant, then + * this header may only to provide the required <stdint.h> (which may be the Grammar, fix by s/only to/just/. +++ m4/_inttypes_h.m4 11 Apr 2006 14:27:29 -0000 @@ -0,0 +1,13 @@ +# _inttypes_h.m4 serial 1 Why does this file need a leading underscore in its name? Nothing else in the m4 directory has one. +++ m4/full-header-path.m4 11 Apr 2006 14:27:29 -0000 +# gl_FULL_HEADER_PATH(HEADER1 HEADER2 ...) +# ---------------------------------------- +# Find the full path to a header file, when the #include_next directive +# doesn't work and the header exists in the first place. If the header were +# sys/inttypes.h (and it existed and #include_next didn't work), this macro +# would define FULL_PATH_SYS_INTTYPES_H to the quoted full path to +# sys/inttypes.h in config.h +# (e.g. `#define FULL_PATH_SYS_INTTYPES_H "/usr/include/sys/inttypes.h"'). ... + AC_CACHE_CHECK([full path to <]m4_quote(m4_defn([gl_HEADER_NAME]))[>], Do we want "" or <> quoting for FULL_PATH_*_H? Probably <>, so the documentation is wrong. AC_DEFINE_UNQUOTED([FULL_PATH_]m4_quote(translit(m4_defn([gl_HEADER_NAME]), + [-./abcdefghijklmnopqrstuvwxyz], Should we make this rely on $as_cr_letters and friends, to make this shorter? - -- Life is short - so eat dessert first! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFERajY84KuGfSFAYARAjR1AJsHxjFhZec6t4iQk14IYyC+BCt2VQCgt6cW vGRd2yQCKMmSUkSmtfpaX2Q= =cdLQ -----END PGP SIGNATURE----- _______________________________________________ Bug-cvs mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/bug-cvs
