While browsing the DejaGnu sources, I noticed that sum2junit.sh appears
to miscount failing tests due to a possible typo on line 49. I am not
sufficiently familiar with JUnit to say with certainty or to be sure of
a correct patch, but this patch at least makes the code and comment
consistent.
---
ChangeLog | 2 ++
contrib/sum2junit.sh | 2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index d1e2267..865b3ef 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -16,6 +16,8 @@
* runtest.exp (load_tool_init): Add message indicating the
expected location of the tool init file.
+ * contrib/sum2junit.sh (failures): Fix typo.
+
2018-10-30 Ben Elliston <[email protected]>
* Makefile.am (DISTCLEANFILES): Add testrun.xml.
diff --git a/contrib/sum2junit.sh b/contrib/sum2junit.sh
index 7d3b0a4..e08f09e 100755
--- a/contrib/sum2junit.sh
+++ b/contrib/sum2junit.sh
@@ -46,7 +46,7 @@ if test x"${passes}" = x; then
fi
# The total of failed results are FAIL and XPASS
-failures=$(grep -E -c '^XFAIL|XPASS' "$infile")
+failures=$(grep -E -c '^FAIL|XPASS' "$infile")
if test x"${failures}" = x; then
failures=0
fi
--
-- Jacob
_______________________________________________
Bug-dejagnu mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-dejagnu
