On Sunday 26 September 2010 22:07:09 Paul Eggert wrote:
> On 09/26/2010 07:56 AM, Duncan Moore wrote:
> > 1) --quote-filenames
> >    Filename quoting.
> 
> I'd rather that troublsome file names always be quoted, instead of 
> having an option that quotes them.  Diff already has too many options.

I agree.

> The implementation can use the already-existing code to quote file
> names, taken from gnulib.

Git defines a format for filename quoting that is already pretty wide spread; 
I don't think there is a reason for not using the same rules.  As an added 
benefit, the current alpha version of GNU patch already understands the GIT 
filename quoting rules; supporting more than one quoting style would be 
difficult in patch.  The rules implemented right now are:

        If a filename contains characters which need quoting, the entire 
filename is
        enclosed in double quotes, and the following escape escape sequences 
are used
        as in C string literals: \\, \", \a, \b, \f, \n, \r, \t, \v, and \ooo (a
        three-digit octal number between 0 and 255).

Do we need more that that?

Thanks,
Andreas

Reply via email to