On Fri, Aug 5, 2016 at 8:48 AM, Assaf Gordon <assafgor...@gmail.com> wrote: > Hello Jim, Dagobert, > > On 08/05/2016 11:03 AM, Jim Meyering wrote: >>> >>> Unfortunately I cannot bootstrap right now as my gettext is too old and I >>> haven’t finished >>> an updated package yet, so I guess I’ll have to wait for the next >>> bootstrapped tarball. >> >> >> Thanks for trying. >> Please let me know the GNU make version: gmake --version should print it. >> Also, you can apply that patch to the Makefile.in (not .am) file in >> the latest pre-release tarball to test it without having to >> re-bootstrap everything. >> If I'm going to commit a work-around patch like that, I'd like to know >> why (have to explain in the commit log, after all), and to be sure >> that it is actually a fix. Notice how /bin/sh is mentioned in your >> diagnostic. I wouldn't be surprised if it is involved. > > > A temporary tarball with the extra patch is here: > http://files.housegordon.org/tmp/diffutils-3.3.58-4e2b3.tar.xz > > With it, there are no test failures on various machines I used, > including OpenSolaris 5.10/5.11 x86/sparc. > > I'm testing on the OpenCSW machines (generously provided by Dagobert), > but it's possible my environment differs. > > I'm using: > > PATH=/usr/gnu/bin:/usr/xpg6/bin:/usr/xpg4/bin/:/opt/csw/bin:usr/sfw/bin:/usr/bin:/bin > SHELL=/opt/csw/bin/bash > > On 5.11 it's gnu-make 3.82, > On 5.10 it's a non-gnu make.
Thank you. With that, I will soon push the attached (reformatted) patch and make one more snapshot.
From 91d23408864f70ce2da19d0b272b298e72fad018 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@fb.com> Date: Sat, 6 Aug 2016 11:19:07 -0700 Subject: [PATCH] tests: tweak built_programs definition * tests/Makefile.am (built_programs): Adjust to work around what may be a problem due to interaction between Solaris 10's /bin/sh and an old version of GNU make. Reported by Dagobert Michelsen in https https://bugs.gnu.org/24137. --- tests/Makefile.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index e8a36ac..77d9fc3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -79,7 +79,11 @@ LOG_COMPILER= $(SHELL) built_programs = \ echo 'spy:;@echo $$(PROGRAMS)' \ - | (cd ../src && MAKEFLAGS= $(MAKE) -s -f Makefile -f - spy) \ - | tr ' ' '\n' | sed '/^$$/d; s,$(EXEEXT)$$,,' | sort -u + | { (cd ../src && MAKEFLAGS= $(MAKE) -s -f Makefile -f - spy) \ + | tr ' ' '\n' \ + | sed '/^$$/d; s,$(EXEEXT)$$,,' \ + | sort -u \ + | tr '\n' ' '; echo; } \ + | sed 's/ $$//' VERBOSE = yes -- 2.8.0-rc2
