I'm embarrassed to say that I've been intending to write this modification
for almost two years now
(http://mail.gnu.org/pipermail/bug-fileutils/1999-December/000517.html).

The main barrier I've faced in sitting down to code this is understanding
exactly all the effects of the call to human_readable() with stat.st_size
in ls.c.  I think human_readable() is doing both format conversions (with
suffixes) and block size conversions.  Here are the relevant lines:

else
  {
    char hbuf[LONGEST_HUMAN_READABLE + 1];
    sprintf (p, "%8s ",
             human_readable ((uintmax_t) f->stat.st_size, hbuf, 1,
                       output_block_size < 0 ? output_block_size : 1));
  }


In any event, I'll take another look at it this week and see if I can get
a patch out soon for this.

--John Saalwaechter

>Date: Wed, 19 Sep 2001 09:44:37 -0600
>From: Alvin Austin <[EMAIL PROTECTED]>
>Organization: Critical Logic & Design, Inc.
>To: [EMAIL PROTECTED]
>Subject: Re: "ls" in fileutils-4.0-13mdk
>
>Suggestion: In "ls -l" commands, it would be nice to have an option to
use
>commas (and maybe also, the locale setting LC_NUMERIC) to display the
file
>size.  With larger files nowadays, it is much easier to read the size as:
>
>    -rw-r--r--    1 root     root    141,804,295 Sep 19 09:38 data04
>
>instead of :
>
>    -rw-r--r--    1 root     root    141804295 Sep 19 09:38 data04
>
>Thanks, and keep up the good work!
>
>Alvin
>--
>Alvin Austin                          Email: [EMAIL PROTECTED]


=====
--
John Saalwaechter <[EMAIL PROTECTED]>

__________________________________________________
Terrorist Attacks on U.S. - How can you help?
Donate cash, emergency relief information
http://dailynews.yahoo.com/fc/US/Emergency_Information/

_______________________________________________
Bug-fileutils mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-fileutils

Reply via email to