[+findutils ML]
Hi Colin,
On 6/24/24 9:00 AM, Collin Funk wrote:
Hi Bernhard,
Bernhard Voelker <m...@bernhard-voelker.de> writes:
thanks for the heads-up, but findutils doesn't have 5c2e65d9c760 (June 12),
but is on the older commit 623bcc22f474 from (May 27); hence the bug is/was
not yet there. :-)
Sorry, my explanation was not very detailed. The patch that I just
committed was not the bug that I was referring to. It was fixing a typo
made in a fix for a previous bug [1].
I left out the explanation since most of those packages were maintained
by Paul, Bruno, and Jim who were CC'd in that mail.
Here is a test in diffutils:
$ ls /tmp
gnulib-python-cache-collin ssh-SmpEba0I2NwE
$ make check
$ find /tmp -name '-p*' | wc -l
31
This is because for a long time tests/init.sh used this command:
mktemp -d -t -p "$destdir_" "$template_";
The problem occurs because BSD mktemp -t expects an argument unlike
Coreutils mktemp -t. The command is not standard so either behavior is
fine. Not the end of the world, but I recommended updating to avoid the
spam of directories in /tmp for the BSD people. We should be nice to
them too. :)
[...]
In that thread Bruno and I were discussing the right way to import that
file into a projects own test suite. Once we have a solution I can
submit a patch if you would like. [...]
Collin
[1] https://lists.gnu.org/archive/html/bug-gnulib/2024-06/msg00090.html
In findutils, there are several files sync'ed from gnulib, and we usually
do that during each gnulib update ... there's even a make target for this:
$ GIT_PAGER= git grep -A18 update-gnulib-to-latest -- Makefile.am
Makefile.am:.PHONY: gnulib-sync update-gnulib-to-latest
Makefile.am:gnulib-sync update-gnulib-to-latest:
Makefile.am- @( cd $(srcdir) \
Makefile.am- && { printf 'gnulib: ' && git -C gnulib describe --always
--dirty \
Makefile.am- && printf 'findutils: ' && git describe --always
--dirty \
Makefile.am- || echo dirty; \
Makefile.am- } | grep 'dirty$$' \
Makefile.am- && { echo "error: tree is dirty" >&2; exit 1; }
|| : \
Makefile.am- && git submodule foreach git pull origin master \
Makefile.am- && cp -v gnulib/doc/COPYINGv3 COPYING \
Makefile.am- && cp -v gnulib/doc/fdl.texi doc/fdl.texi \
Makefile.am- && cp -v gnulib/top/autogen.sh autogen.sh \
Makefile.am- && cp -v gnulib/top/autopull.sh autopull.sh \
Makefile.am- && cp -v gnulib/top/bootstrap bootstrap \
Makefile.am- && cp -v gnulib/top/bootstrap-funclib.sh
bootstrap-funclib.sh \
Makefile.am- && cp -v gnulib/tests/init.sh tests/init.sh \
Makefile.am- && git status --short -- gnulib COPYING doc/fdl.texi
autogen.sh \
Makefile.am- autopull.sh bootstrap bootstrap-funclib.sh
tests/init.sh \
Makefile.am- tests/init.sh \
Makefile.am- )
Some of the files have to be physically copied into the version control like
COPYING
and the 'fdl.texi', for other files we wanted to keep track of changes.
This is the same in coreutils.
Hence, the change in tests/init.sh will come with the next gnulib update
which I'll eventually do in the next couple of days.
Have a nice day,
Berny
