Hi Dave,
On 9/13/24 10:12, Dave wrote:
From 2a83f217df3469eec4226255ab9d27251dd8f2ba Mon Sep 17 00:00:00 2001
From: Dave <dj.2d...@gmail.com>
Date: Fri, 13 Sep 2024 07:53:31 +0000
Subject: [PATCH] find: add bison as a requirement for compiling
*README-hacking(prerequisites): Compiling without bison would result in
`fatal error: parse-datetime.c: No such file or directory` which is not
a very helpful error message.
---
README-hacking | 1 +
1 file changed, 1 insertion(+)
diff --git a/README-hacking b/README-hacking
index 0d96dc84..13f91b3d 100644
--- a/README-hacking
+++ b/README-hacking
@@ -17,6 +17,7 @@ Prerequisites
* GNU m4
* GNU gettext
* GNU Dejagnu
+ * GNU Bison
Dejagnu is in fact optional, but it's strongly recommended, since it is
needed to run findutils' test suite (which is how you know that find
many thanks for the report.
Additionally to just adding Bison to maintainer README, I'd also add it
as a real prerequisite for the bootstrap process by gnulib, so that the
build would fail much earlier:
$ ./bootstrap
./bootstrap: Error: 'bison' not found
./bootstrap: Please install the prerequisite programs
I've tweaked the patch and would push the attached in your name, if you agree.
Thanks & have a nice day,
Berny
From 92b3f774bef5fe0665df0444a621e20a0a816992 Mon Sep 17 00:00:00 2001
From: Dave <dj.2d...@gmail.com>
Date: Fri, 13 Sep 2024 07:53:31 +0000
Subject: [PATCH] build: add bison as requirement
Building from git without bison available would result in
cc1: fatal error: ./parse-datetime.c: No such file or directory
which is not a very helpful error message.
Let gnulib bootstrap check for bison much earlier.
* README-hacking (Prerequisites): Add Bison explicitly.
* bootstrap.conf (buildreq): Add bison.
* cfg.mk (bootstrap-tools): Add gnulib variable with tools including
bison.
Co-authored-by: Bernhard Voelker <m...@bernhard-voelker.de>
Copyright-paperwork-exempt: Yes
---
README-hacking | 1 +
bootstrap.conf | 1 +
cfg.mk | 3 +++
3 files changed, 5 insertions(+)
diff --git a/README-hacking b/README-hacking
index 0d96dc84..53ae3f2d 100644
--- a/README-hacking
+++ b/README-hacking
@@ -14,6 +14,7 @@ Prerequisites
on a POSIX system should work.
* GNU Autoconf
* GNU Automake
+ * GNU Bison
* GNU m4
* GNU gettext
* GNU Dejagnu
diff --git a/bootstrap.conf b/bootstrap.conf
index 00203844..39c17e58 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -273,6 +273,7 @@ buildreq="\
autoconf 2.64
automake 1.11.2
autopoint 0.19.2
+bison -
gettext 0.19.2
git 1.5.5
m4 -
diff --git a/cfg.mk b/cfg.mk
index 4d72d922..dc13c346 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -21,6 +21,9 @@ gendocs_options_ = -s find.texi -I $(abs_builddir)/doc
local-checks-to-skip :=
+# Tools used to bootstrap this package, used for "announcement".
+bootstrap-tools = autoconf,automake,gnulib,bison
+
# Errors I think are too picky anyway.
local-checks-to-skip += sc_error_message_period sc_error_message_uppercase \
sc_file_system sc_indent
--
2.46.0
