On 3/14/25 22:45, raf wrote:
On Fri, Mar 14, 2025 at 09:11:01AM +0100, Bernhard Voelker
<m...@bernhard-voelker.de> wrote:
What worries me more is the use of the extra dash '-' for the logical elements
'-)' and '-!'.
What exactly needs to be fixed?
Find should not allow things like '-!'.
Why is accepting a - prefix a downside?
- it's ugly to read or write first of all,
- it's redundant to the regular '!', ',' '(' and ')' punctuation operators,
- it's not mandated by any specification,
- it's not supported by any other reference implementations,
- it's inadvertently happening by some blurry corners of the code,
- it's not documented.
- it's not tested.
Is it just that it's undocumented/unintended behaviour?
yes, and more: it's an implementation bug I would say.
That just slipped through.
Things like this bug are impossible to see by just reading the code.
Eventually a fuzzing tool may find that unintended behavior.
We should clear that code area and simplify it.
Readability helps for better maintainability.
cheers,
raf
Have a nice day,
Berny
