On 7/13/26 02:49, James Youngman wrote:
Because the public tree was already broken (i.e. tests did not pass) I
pushed this patch without waiting for feedback. If there are
problems with it at least they're less bad.
Sorry about the breakage,
Thanks for fixing.
As a quick fix, I pushed the attached follow-up commit to fix the new tests.
- fix group check: I assume that you locally are using a group name
which is identical to your user name?
- tests shall be executable, otherwise syntax-check complains.
I'll check a bit more on the patches later.
Have a nice day,
Berny
From 635998b4d9c86ae1ba70c058b8f022a2ce80ab17 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <[email protected]>
Date: Mon, 13 Jul 2026 08:40:58 +0200
Subject: [PATCH] tests: fix new find -ls tests
* tests/find/ls-format-symlink.sh: Make executable.
* tests/find/ls-format-file.sh: Likewise.
Additionally, compare with 'gowner' for the group name.
---
tests/find/ls-format-file.sh | 4 ++--
tests/find/ls-format-symlink.sh | 0
2 files changed, 2 insertions(+), 2 deletions(-)
mode change 100644 => 100755 tests/find/ls-format-file.sh
mode change 100644 => 100755 tests/find/ls-format-symlink.sh
diff --git a/tests/find/ls-format-file.sh b/tests/find/ls-format-file.sh
old mode 100644
new mode 100755
index b5772536..9a9989d0
--- a/tests/find/ls-format-file.sh
+++ b/tests/find/ls-format-file.sh
@@ -170,9 +170,9 @@ NR == 1 {
printf("%s: owner %s looks OK\n", ME, st_uid);
}
# field 6 is the group owner
- if (st_gid != uowner) {
+ if (st_gid != gowner) {
rv=1
- printf("%s: failed test: expected group owner [%s], got [%s]\n", ME, uowner, st_gid);
+ printf("%s: failed test: expected group owner [%s], got [%s]\n", ME, gowner, st_gid);
} else {
printf("%s: group owner %s looks OK\n", ME, st_gid);
}
diff --git a/tests/find/ls-format-symlink.sh b/tests/find/ls-format-symlink.sh
old mode 100644
new mode 100755
--
2.54.0
