Hi Daiki. On 05/28/2013 03:57 AM, Daiki Ueno wrote: > Hi Stefano, > > Stefano Lattarini <[email protected]> writes: > >> * gettext-tools/tests/Makefile.am (TESTS_ENVIRONMENT): Remove >> trailing '$(SHELL)'. With the parallel-tests harness, this is >> no longer the correct way to define a custom test runner for >> the test scripts; to do so, we have to ... >> (LOG_COMPILER): ... define this to $(SHELL). > > Now that $(SHELL) at the end of TEST_ENVIRONMENT started signalling > error with Automake 1.13, we need this change. However, I'm still not > sure if 'parallel-tests' option is safe. Last time I tested it with > earlier Automake versions, it caused some errors with conflicting temp > file names. > Note that 'parallel-tests' is the default in Automake 1.13, so, if you don't fix those conflicts, you will likely encounter spurious testsuite failures when Gettext is bootstrapped with Automake >= 1.13. (See below for a possible hack to avoid this).
> So, I'm going to install LOG_COMPILER change only at the moment (patch > attached). Is it fine with you? > No, because in Automake 1.11 and 1.12 the $(LOG_COMPILER) variable is not used if the parallel testsuite harness is not activated, and activating it requires the 'parallel-tests' option. If you don't want to go and fix the testsuite to be parallel-tests compatible right now, you might want to enhance the autogen.sh script to detect whether Automake >= 1.13 is in use, and if it is, pass it the 'serial-tests' option (unfortunately not present in Automake 1.11) that will instruct it to keep using the older serial testsuite driver (which is discouraged, but not actually deprecated: there are no plans to ever remove it). HTH, Stefano
