Miguel Ángel Arruga Vivas <[email protected]> writes: > Daiki Ueno <[email protected]> wrote: >> Given that keywords can only be specified for Glade 1 (as documented), >> it would make more sense to just ignore it for Glade 2 and 3, IMO. > > This one ignore this flag for Glade 2 and 3 files.
Looks good, thanks. One minor comment: it is not too intuitive that p->extract_string means --extract-all, by looking at start_element_glade2 and start_element_gtkbuilder. Maybe start_element_handler could initialize p->extract_string as false, and start_element_glade1 could check extract_all by itself? Anyway, feel free to commit this. Regards, -- Daiki Ueno
