On Tue, Sep 14, 2021 at 03:00:30PM +0000, Aaron Tikuisis wrote: > I think I'd rather just post the code on savannah. I see that there > have been changes to the code since the version we worked with, so I > will merge and check that there are no conflicts, in the next few > days, before posting.
Hello Aaron, I don't understand what you mean by "posting the code on savannah". As far as I can see you have an account there but it has not been added to the gnubg project, at least not yet, so you cannot commit it at this time. On the other hand, Isaac's account is in the gnubg developers and he commited the first version of your changes in a "score" branch: https://cvs.savannah.gnu.org/viewvc/gnubg/gnubg/?sortby=date&pathrev=score#dirlist There really were two independant features: money eval button for cube decisions (that worked fine) and scoremap widget (that was crash-prone at the time). If you made no further changes in the money eval part, I could pick them from this branch an apply them first. I think the involved files are split this way: Makefile.am scoremap commands.inc scoremap backgammon.h money + scoremap gtkchequer.h scoremap gtkcube.h money gtkuidefs.h scoremap gtkscoremap.h scoremap gtkchequer.c money + scoremap gtkcube.c money gtktempmap.c money gtkgame.c money play.c money show.c money + scoremap gtkscoremap.c scoremap A few other commited by pif from the top of the list at the above URL are either small independant changes (like the drawboard.*) or minor mistakes (like the *_l.[ch] or *_y.[ch] that are not sources but created from the corresponding *.l or *.y files) That would decrease the differences by about half, in term of files involved, but would be useful only if the money button part didn't change at all since then. In the other case, I think it still would be useful to commit the features separately in two steps, but it would be premature to begin from the old branch.
