Hi,
Philippe Michel <[email protected]> writes:
> It looks like the alternatives would be to have the actionEntries table
> non static, which may be somewhat complicated, or to use "Move" for move
> as a noun and "verb|Move" for move as a verb. The latter seems the more
> practical choice.
Thanks for changes.
sound_description[] in sound.c should be sync with description in commands.inc.
In commands.inc:
{ "move", CommandSetSoundSoundMove,
N_("verb|move"), szOPTFILENAME, &cFilename },
But N_("Move") in sound_description[].
Perhaps the inconsistency is due to a patch I submitted.
I made patches to sync them.
- Sync N_("verb|Move") : movesound.diff
- Sync N_("Confirm move") : movesound-confirm.diff
The timing of the move.wav sound is click after chequer movement(turn end).
I would prefer the N_("Confirm move"), in my view.
Best regards,
--
TAKAHASHI Kaoru
Index: sound.c
===================================================================
RCS file: /sources/gnubg/gnubg/sound.c,v
retrieving revision 1.108
diff -u -r1.108 sound.c
--- sound.c 17 Feb 2024 17:39:26 -0000 1.108
+++ sound.c 20 Feb 2024 16:22:28 -0000
@@ -348,7 +348,7 @@
N_("Doubling"),
N_("Drop"),
N_("Chequer movement"),
- N_("Move"),
+ N_("verb|Move"),
N_("Redouble"),
N_("Resign"),
N_("verb|Roll"),
Index: commands.inc
===================================================================
RCS file: /sources/gnubg/gnubg/commands.inc,v
retrieving revision 1.70
diff -u -p -u -r1.70 commands.inc
--- commands.inc 20 Nov 2023 21:00:06 -0000 1.70
+++ commands.inc 20 Feb 2024 16:26:48 -0000
@@ -1043,7 +1043,7 @@ static command acSetExportHTMLType[] = {
{ "humanwinsmatch", CommandSetSoundSoundHumanWinMatch,
N_("Human wins match"), szOPTFILENAME, &cFilename },
{ "move", CommandSetSoundSoundMove,
- N_("verb|Move"), szOPTFILENAME, &cFilename },
+ N_("Confirm move"), szOPTFILENAME, &cFilename },
{ "redouble", CommandSetSoundSoundRedouble,
N_("Redouble"), szOPTFILENAME, &cFilename },
{ "resign", CommandSetSoundSoundResign,
Index: sound.c
===================================================================
RCS file: /sources/gnubg/gnubg/sound.c,v
retrieving revision 1.108
diff -u -p -u -r1.108 sound.c
--- sound.c 17 Feb 2024 17:39:26 -0000 1.108
+++ sound.c 20 Feb 2024 16:26:48 -0000
@@ -348,7 +348,7 @@ const char *sound_description[NUM_SOUNDS
N_("Doubling"),
N_("Drop"),
N_("Chequer movement"),
- N_("Move"),
+ N_("Confirm move"),
N_("Redouble"),
N_("Resign"),
N_("verb|Roll"),
