Paul Eggert wrote:
> With [4] in place, I guess Pádraig's point is that Bruno's older Gnulib
> patch[5] is no longer needed.
I just tried that: Reverting this patch:
@@ -33,7 +47,12 @@
static int
is_attr_permissions (const char *name, struct error_context *ctx)
{
- return attr_copy_action (name, ctx) == ATTR_ACTION_PERMISSIONS;
+ /* We need to explicitly test for the known extended attribute names,
+ because at least on CentOS 7, attr_copy_action does not do it. */
+ return strcmp (name, XATTR_NAME_POSIX_ACL_ACCESS) == 0
+ || strcmp (name, XATTR_NAME_POSIX_ACL_DEFAULT) == 0
+ || strcmp (name, XATTR_NAME_NFSV4_ACL) == 0
+ || attr_copy_action (name, ctx) == ATTR_ACTION_PERMISSIONS;
}
#endif /* USE_XATTR */
On CentOS 7, this causes 6 test failures:
FAIL: test-copy-acl.sh
FAIL: test-copy-acl-1.sh
FAIL: test-copy-acl-2.sh
FAIL: test-copy-file.sh
FAIL: test-copy-file-1.sh
FAIL: test-copy-file-2.sh
So, no, [5] is not made redundant by [4].
Bruno
> [4]:
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=8a356b77717a2e4f735ec06e326880ca1f61aadb
> [5]:
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=47947855dda53fd12bbae2a0fccecb2280577a60
