Derek Price <[EMAIL PROTECTED]> wrote: > I've installed the attached patch. It is almost identical to my > previous one, with a few extra portability and typo fixes. > > 2005-09-12 Derek Price <[EMAIL PROTECTED]> > > * modules/canon-host: Add canon-host.h. Depend on getaddrinfo. Make > LGPL. > * modules/getaddrinfo: Add link to opengroup spec. Depend on strdup.
Thanks for doing all of that. There is one small problem. When strdup returns NULL, canon_host_r returns NULL without setting *cherror. Shouldn't that be fixed? I've checked in these cosmetic changes: That file was using an indentation style different from the style used in nearly every other source file. I ran it through GNU indent. Finally, we prefer to use an active voice (rather than passive voice) in comments. So I changed this: /* Returns a malloc'd string containing the canonical hostname associated with HOST, or NULL if a canonical name cannot be determined. On NULL return, if CHERROR is not NULL, *CHERROR will be set to an error code as returned by getaddrinfo(). Error codes from CHERROR may be converted to a string suitable for error messages by ch_strerror_r() or gai_strerror(). to this: /* Return a malloc'd string containing the canonical hostname associated with HOST, or NULL if a canonical name cannot be determined. On NULL return, if CHERROR is not NULL, set *CHERROR to an error code as returned by getaddrinfo(). Use ch_strerror_r() or gai_strerror() to convert a *CHERROR value to a string suitable for error messages. _______________________________________________ bug-gnulib mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-gnulib
