Eric Blake wrote:
> a useful va_list error variant for use in m4, I propose this new module.  
> Any objections to installing this?

It looks alright, except for the Ben's comment and this:

> +  AC_LIBSOURCES([verror.c, verror.h])
> +  AC_LIBOBJ([verror])

This makes it impossible to use this module as-is in a package that uses
gnulib with a --source-base different from 'lib'. Jim and Paul have introduced
this style of writing gnulib modules, but this style and some hardcoded rules
in automake together cause major hassles to the other users of gnulib-tool.

You avoid the problem by removing these two lines from the macro file and
adding
   lib_SOURCES += verror.h verror.c
to the module description.

Bruno


Reply via email to