Simon Josefsson <simon <at> josefsson.org> writes: > > A patch explains what I mean more clear. Skip your patch, and apply > this instead. There already was a git-version-gen module. What do you > think?
Looks nice. Please apply, with these nits fixed: > # Ensure that $(VERSION) is up to date for dist-related targets, but not > # for others: rerunning autoreconf and recompiling everything isn't cheap. > -ifeq (0,$(MAKELEVEL)) > +_have-git-version-gen := $(shell test -f ./build-aux/git-version-gen && echo yes) Do we want to hard-code build-aux? Or should we do: _build-aux ?= build-aux ./$(_build-aux)/git-version-gen > +ifeq ($(_have-git-version-gen),yes) > + ifeq (0,$(MAKELEVEL)) > _is-dist-target = $(filter-out %clean, \ I like two space indents. But rather than reindent everything, will it work to combine the two conditions into one test? ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL)) -- Eric Blake
