Bruno Haible <[EMAIL PROTECTED]> wrote:
> On MacOS X the testsuite still fails:
...
> Please review (although I commit it immediately, because more patches are
> coming.)
...
> +  if (ret != 0)
> +    {
> +      int saved_errno = errno;
> +
> +      if (ACL_NOT_WELL_SUPPORTED (errno) && !(acl_entries (acl) > 0))
> +        {

Why use the negation?  I prefer this:

         if (ACL_NOT_WELL_SUPPORTED (errno) && acl_entries (acl) <= 0)

Otherwise, it all looks fine.


Reply via email to