On Sat, 9 Aug 2008, Joel E. Denny wrote:
> I frequently run make maintainer-check during Bison development. I don't
> see a need to update VERSION every time. Is the following patch
> acceptable, or would it be better to rename maintainer-check* to something
> else in Bison?
Here's a more formal version of the patch I posted earlier this month.
Is there a better way to handle this?
>From f540aa20ba1c86a70d337f2ab0c688bce5d2afb4 Mon Sep 17 00:00:00 2001
From: Joel E. Denny <[EMAIL PROTECTED]>
Date: Tue, 26 Aug 2008 02:57:12 -0400
Subject: [PATCH] Don't update $(VERSION) for maintainer-check* targets.
Such targets are used by some developers frequently during development.
* top/GNUmakefile: Implement.
---
ChangeLog | 6 ++++++
top/GNUmakefile | 2 +-
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 365531e..930f996 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-08-26 Joel E. Denny <[EMAIL PROTECTED]>
+
+ Don't update $(VERSION) for maintainer-check* targets.
+ Such targets are used by some developers frequently during development.
+ * top/GNUmakefile: Implement.
+
2008-08-26 Bruno Haible <[EMAIL PROTECTED]>
Run makeinfo in an English locale.
diff --git a/top/GNUmakefile b/top/GNUmakefile
index 7635e8d..86ad493 100644
--- a/top/GNUmakefile
+++ b/top/GNUmakefile
@@ -53,7 +53,7 @@ _autoreconf ?= autoreconf
_have-git-version-gen := \
$(shell test -f $(srcdir)/$(_build-aux)/git-version-gen && echo yes)
ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
- _is-dist-target = $(filter-out %clean, \
+ _is-dist-target = $(filter-out maintainer-check% %clean, \
$(filter maintainer-% dist% alpha beta major,$(MAKECMDGOALS)))
_is-install-target = $(filter-out %check, $(filter install%,$(MAKECMDGOALS)))
ifneq (,$(_is-dist-target)$(_is-install-target))
--
1.5.4.3
