Hello Richard, a couple of nits:
* Richard W.M. Jones wrote on Thu, Oct 23, 2008 at 07:35:09PM CEST: > + AC_CHECK_FUNCS([drand48 erand48 lrand48 nrand48 mrand48 jrand48 srand48 > seed48 lcong48 drand48_r erand48_r lrand48_r nrand48_r mrand48_r jrand48_r > srand48_r seed48_r lcong48_r]) Please wrap long lines. > + if test $ac_cv_func_drand48 = no -o $ac_cv_func_erand48 = no -o > $ac_cv_func_lrand48 = no -o $ac_cv_func_nrand48 = no -o $ac_cv_func_mrand48 = > no -o $ac_cv_func_jrand48 = no -o $ac_cv_func_srand48 = no -o > $ac_cv_func_seed48 = no -o $ac_cv_func_lcong48 = no -o $ac_cv_func_drand48_r > = no -o $ac_cv_func_erand48_r = no -o $ac_cv_func_lrand48_r = no -o > $ac_cv_func_nrand48_r = no -o $ac_cv_func_mrand48_r = no -o > $ac_cv_func_jrand48_r = no -o $ac_cv_func_srand48_r = no -o > $ac_cv_func_seed48_r = no -o $ac_cv_func_lcong48_r = no ; then Likewise. Also, please do not use 'test ... -o ...', as it's not Posix, only XSI. You can use test $x = no || test $y = no || ... FWIW, I otherwise haven't looked at the patch at all. Thanks, Ralf
