Michel Boaventura reported the following link errors trying to
compile GNU PSPP on mingw:

> gl/.libs/libgl.a(close.o):close.c:(.text+0x2d): undefined reference to
> [EMAIL PROTECTED]'
> gl/.libs/libgl.a(close.o):close.c:(.text+0x45): undefined reference to
> [EMAIL PROTECTED]'
> gl/.libs/libgl.a(close.o):close.c:(.text+0x51): undefined reference to
> [EMAIL PROTECTED]'
> gl/.libs/libgl.a(close.o):close.c:(.text+0x5f): undefined reference to
> [EMAIL PROTECTED]'

It looks like the gnulib close module needs to recommend linking
against the ws2_32 library on Windows.  Or perhaps it should add
it directly to LIBS, since the "close" function is so basic that
it seems odd to have to add to LDADD to be able to use it.

I think that the former can be implemented like this:

diff --git a/m4/close.m4 b/m4/close.m4
index fcc9fb1..29d3abd 100644
--- a/m4/close.m4
+++ b/m4/close.m4
@@ -22,4 +22,6 @@ AC_DEFUN([gl_REPLACE_CLOSE],
   fi
   REPLACE_CLOSE=1
   gl_REPLACE_FCLOSE
+  LIB_CLOSE="-lws2_32"
+  AC_SUBST([LIB_CLOSE])
 ])
diff --git a/modules/close b/modules/close
index bb852d4..138be1b 100644
--- a/modules/close
+++ b/modules/close
@@ -19,6 +19,9 @@ Makefile.am:
 Include:
 <unistd.h>
 
+Link:
+$(LIB_CLOSE)
+
 License:
 LGPLv2+
 

-- 
Ben Pfaff 
http://benpfaff.org


Reply via email to