Hi Simon, * Simon Josefsson wrote on Mon, Nov 10, 2008 at 07:09:30PM CET: > I want to add some warning flags from configure, including -Werror. > > Using CFLAGS doesn't seem to be a good idea (some autoconf tests stops > working),
Also, some flags influence the preprocessor, too. > so how about something like this module? I'm indifferent, except that a better werror framework in Autoconf could make your approach obsolete. > + AC_COMPILE_IFELSE(AC_LANG_PROGRAM([]), foo=yes, foo=no) This looks M4-underquoted; also, 'foo' seems such an arbitrary name. How about gl_warning_works? Please note that the next GCC release will handle -Wno* switches that it does not know about differently than older ones: it will not error out about them; it will warn about them, but *only* if there is at least one other warning in the output. Also, how come you do not cache your test results? (You'd need a cache variable that contains the warning name, AS_TR_SH-translated). > +License: > +LGPLv2+ If the module contains nothing but Autoconf macro code, it is IMVHO more useful to just be free about it, no? Don't all of gnulib m4 macros use the license exception Autoconf uses? Cheers, Ralf
