Eric Blake wrote: > According to Simon Josefsson on 4/27/2009 6:19 AM: >>> The intent is that your cfg.mk should point to the location where you >>> expect to find a fresh gnulib checkout, so that you DON'T have to add >>> a dependency on vc-list-files or useless-if-before-free. Using >>> maint.mk from gnulib implies that you have gnulib installed, which is >>> why I was okay writing it in this way. >> >> I don't think that is true -- I have been using maint.mk in several >> projects without requiring a locally installed gnulib repository for >> bootstrapping. >> Given the above, this seems wrong to me. Instead, why don't maint.mk >> use the local build-aux/ path? Right now it looks in the gnulib >> directory (gnulib/) but the right thing seems like the maintainer should >> --import vc-list-files and useless-if-before-free (possibly >> maintainer-makefile should depend on them) and then maint.mk should call >> the files from the locally imported build-aux/ directory. Right? > > Yes, if we go this route, then we should make the maintainer-makefile > module depend on both vc-list-files and useless-if-before-free. I almost > made this change as part of porting maint.mk to work with m4, but didn't > do it because m4 falls in the first camp (bootstrap requires a gnulib > checkout), but your arguments for the second camp (bootstrap is > independent of gnulib) are good, so how about this patch instead?
Yes, I prefer this. > vc-list-files is a definite dependency, although I could be convinced to > drop the dependency on useless-if-before-free for projects that choose to > skip that particular syntax check, provided we also rewrite that check to > first validate that build-aux/useless-if-before-free has been imported. ... >>From 3262ad571e1c6dbfde5e7350e2d5745d59b72fcb Mon Sep 17 00:00:00 2001 > From: Eric Blake <[email protected]> > Date: Mon, 27 Apr 2009 06:27:04 -0600 > Subject: [PATCH] maintainer-makefile: depend on all required helper scripts > > * modules/maintainer-makefile (Depends-on): Add vc-list-files and > useless-if-before-free. > * top/maint.mk (VC_LIST, sc_avoid_if_before_free): Use local > version, rather than assuming gnulib checkout is available. > Reported by Simen Josefsson.
