Bruno Haible <br...@clisp.org> ha escrit: > - Do you really need *two* array-taking functions?
Yes, I believe so. I could remove one of them, but that would make the interface more awkward. E.g. retaining only version_etc_ar would mean extra iteration when called from version_etc_va. On the other hand, retaining only version_etc_arn will mean that argp_version_setup needs to compute the number of elements in the array. > +/* Like version_etc, below, but with the NULL-terminated author list > + provided via a variable of type va_list. */ > > Ouch! Not only you expect the user to look up the documentation of the > API inside a long source file, but you also play paper chase with the > user. Not me :^) It was the original comment in version_etc.c. I did not touch it. > Please commit the two module changes as distinct commits in git. Yes, that was intended. Thanks for your feedback. I'll fix those issues and commit the stuff. Regards, Sergey