Re: [PATCH] popen-safer: test O_CLOEXEC at run-time.

[Paolo Bonzini]

+#ifdef O_CLOEXEC
+  /* 0 = unknown, 1 = yes, -1 = no.  */
+  static bool have_cloexec;

This has to be an int, not a bool, per the documented semantics you gave it.

Right.

+  if (have_cloexec>= 0)
+    {
+      fd = open (name, flags | O_CLOEXEC);

                                ^
Not sure how that 8-bit character got there.

Since it was a git-send-email message, I'm not sure too...

Paolo