Bruno Haible wrote: > Here is a proposal to add a module 'mkostemp', using the source code changes > from glibc. It also reduces the diffs to glibc, by incorporating parts of this > glibc commit: > > http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=d7e23b02a40384be1eaf00762ea36fd117c462cd > > Opinions? Objections? > > > 2009-08-22 Bruno Haible <[email protected]> > > New module 'mkostemp'. > * lib/stdlib.in.h (mksotemp): New declaration. > * lib/mkostemp.c: New file, from glibc with modifications. > * lib/tempname.h (GT_FILE): Remove outdated comment. > (gen_tempname): Add flags argument. > * lib/tempname.c (__GT_BIGFILE): Remove macro. > (__GT_FILE): Map to 1. > (small_open, large_open): Remove macros. > (__gen_tempname): Add flags argument. Remove code for __GT_BIGFILE. > * lib/mkstemp.c (mkstemp): Update. > * lib/mkdtemp.c (mkdtemp): Likewise. > * m4/mkostemp.m4: New file. > * m4/stdlib_h.m4 (gl_STDLIB_H_DEFAULTS): Initialize GNULIB_MKOSTEMP, > HAVE_MKOSTEMP. > * modules/stdlib (Makefile.am): Substitute GNULIB_MKOSTEMP, > HAVE_MKOSTEMP. > * modules/mkostemp: New file, based on modules/mkstemp. > * doc/glibc-functions/mkostemp.texi: Mention the new module.
This looks fine. FYI, since it modifies tempname.c and since coreutils has a modified version of that gnulib file, I'll sync the interface changes into coreutils' copy, eventually. coreutils' changes are not library-safe, since the added rand* functions may exit.
