Simon Josefsson wrote: > Pádraig Brady <[email protected]> writes: ... >> I suppose these should include stdint.h also? >> >> areadlink.c:# define SIZE_MAX ((size_t) -1) >> areadlink-with-size.c:# define SIZE_MAX ((size_t) -1) >> backupfile.c:# define SIZE_MAX ((size_t) -1) >> fnmatch.c:# define SIZE_MAX ((size_t) -1) >> quotearg.c:# define SIZE_MAX ((size_t) -1) >> striconv.c:# define SIZE_MAX ((size_t) -1) > > Note that stdint.h may not be sufficient to get SIZE_MAX, quoting > size_max.h: > > /* Get SIZE_MAX declaration on systems like Solaris 7/8/9. */ > # include <limits.h> > /* Get SIZE_MAX declaration on systems like glibc 2. */ > # if HAVE_STDINT_H > # include <stdint.h> > # endif > /* On systems where these include files don't define it, SIZE_MAX is defined > in config.h. */ > > However given that SIZE_MAX should be in stdint.h according to POSIX, > maybe it makes more sense to make sure gnulib's stdint.h replacement is > enabled when SIZE_MAX is not provided by the system's stdint.h? And > then deprecate size_max.h in favor of stdint.
AFAICS, gettext and xsize are the only gnulib modules that use it, so deprecating size_max sounds like a good idea, assuming Bruno doesn't mind adjusting those two modules.
