Hi Eric,

> Yes, autoconf's AC_FUNC_GETLOADAVG should be updated in this manner, and 
> that should also be reflected into gnulib's gl_GETLOADAVG.

As a followup to your fix, I'm adding this change, to make it clear that
libkvm is tested in the same conditions as libelf.


2010-08-24  Bruno Haible  <[email protected]>

        getloadavg: simplify code
        * m4/getloadavg.m4 (gl_GETLOADAVG): Remove useless test of
        gl_have_func. Update comments.

--- m4/getloadavg.m4.orig       Tue Aug 24 21:50:47 2010
+++ m4/getloadavg.m4    Tue Aug 24 21:49:02 2010
@@ -45,11 +45,10 @@
 # Some systems with -lutil have (and need) -lkvm as well, some do not.
 # On Solaris, -lkvm requires nlist from -lelf, so check that first
 # to get the right answer into the cache.
-# For kstat on solaris, we need libelf to force the definition of SVR4 below.
+# For kstat on solaris, we need to test for libelf and libkvm to force the
+# definition of SVR4 below.
 if test $gl_have_func = no; then
   AC_CHECK_LIB([elf], [elf_begin], [LIBS="-lelf $LIBS"])
-fi
-if test $gl_have_func = no; then
   AC_CHECK_LIB([kvm], [kvm_open], [LIBS="-lkvm $LIBS"])
   # Check for the 4.4BSD definition of getloadavg.
   AC_CHECK_LIB([util], [getloadavg],

Reply via email to