Tom G. Christensen wrote: > On Thu, Sep 02, 2010 at 01:53:54PM +0200, Jim Meyering wrote: >> Sure. I've just pushed the following. >> Can someone confirm that 5.6.0 works, or even >> find what precise version is barely new enough? >> > I just tried the test on RHEL 2.1 with perl 5.6.1 > and it fails in the same way. > > The test works on RHEL 3 with perl 5.8.0.
Thanks, Tom. Updated like this: >From 132c58b713b628b98e0e5492a40cc16abe8f16ec Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Thu, 2 Sep 2010 17:53:36 +0200 Subject: [PATCH] test-update-copyright.sh: require perl 5.8.0 * tests/test-update-copyright.sh: Require 5.8.0, which Tom G. Christensen has confirmed is adequate, while 5.6.1 is not. --- ChangeLog | 7 +++++++ tests/test-update-copyright.sh | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 74e4991..93c6b1c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-09-02 Jim Meyering <meyer...@redhat.com> + + test-update-copyright.sh: require perl 5.8.0 + * tests/test-update-copyright.sh: Require 5.8.0, + which Tom G. Christensen has confirmed is adequate, + while 5.6.1 is not. + 2010-09-02 Eric Blake <ebl...@redhat.com> wctype: fix typo in previous commit diff --git a/tests/test-update-copyright.sh b/tests/test-update-copyright.sh index 607928d..09ade03 100755 --- a/tests/test-update-copyright.sh +++ b/tests/test-update-copyright.sh @@ -16,9 +16,9 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# Skip this test if Perl is too old. FIXME: 5.6.0 is just a guess. -# We have a report that 5.004_05 is inadequate and that 5.8.8 works. -perl -e 'require 5.6.0' || exit 77 +# Skip this test if Perl is too old. FIXME: 5.8.0 is just a guess. +# We have a report that 5.6.1 is inadequate and that 5.8.0 works. +perl -e 'require 5.8.0' || exit 77 diffout=`diff -u /dev/null /dev/null 2>&1` if test x"$diffout" = x"" && test $? -eq 0; then -- 1.7.2.2.510.g7180a