On 10/26/2010 02:51 PM, Paul Eggert wrote:
* lib/renameat.c: Include unistd.h before stdio.h, because
Solaris 10 declares renameat in unistd.h.  Problem encountered
when building GNU tar 1.24 on Solaris 10.
---
  ChangeLog      |    8 ++++++++
  lib/renameat.c |    6 ++++++
  2 files changed, 14 insertions(+), 0 deletions(-)

Shouldn't the real fix to be fixing our <stdio.h> replacement to pull in <unistd.h> prior to re-declaring renameat? That is, our goal is that all files except for .m4 probes and our replacement headers should be immune to header reordering issues.

I'll come up with a better patch.

--
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Reply via email to