On 13/12/10 17:50, Paul Eggert wrote: > On 12/13/10 02:09, Pádraig Brady wrote: >> * Keep allocation to multiples of BUFSIZ which may be more efficient > > I don't see how the patch accomplishes this. > If alloc starts off being BUFSIZ, and the assignment > "alloc = alloc + alloc / 2" does not keep the allocation > to a multiple of BUFSIZ. Also, for regular files alloc > might start off being an odd number. >
Oops right, I had dropped some code but forgot to drop the description. Thanks for the review. cheers, Pádraig.
